Fixed issues reported by phpstan #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Steveb-p
reviewed
Oct 2, 2023
Comment on lines
52
to
54
| if ($this->container === null) { | ||
| return new BoostFactorProvider(); | ||
| } |
There was a problem hiding this comment.
Not having a container set at this point indicates an error. LogicException should be preferred in my opinion.
konradoboza
approved these changes
Oct 2, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Steveb-p
approved these changes
Oct 3, 2023
|
Merged. Also merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.5+Fixed issues reported by phpstan in https://github.com/ibexa/solr/actions/runs/6377398486/job/17305988985?pr=51
Checklist:
Provided automated test coverage.$ composer fix-cs).@ibexa/php-devfor back-end changes and/or@ibexa/javascript-devfor front-end changes).