Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7418: Added CriterionVisitior for ContentNameCriterion #61

Merged
merged 4 commits into from
Jan 17, 2024
Merged

IBX-7418: Added CriterionVisitior for ContentNameCriterion #61

merged 4 commits into from
Jan 17, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Dec 19, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-7418
Type feature
Target Ibexa version v4.6
BC breaks no
Related PRs ibexa/core#312, https://github.com/ibexa/elasticsearch/pull/34, ibexa/rest#82

Examples

new ContentName('phrase'); 

new ContentName('phra*'); 

new ContentName('*phrase*'); 

new ContentName('phr*se*');

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for front-end changes).

@ciastektk ciastektk marked this pull request as ready for review December 19, 2023 12:00
@ciastektk ciastektk force-pushed the ibx-7418-added-criterion-visitior-for-content-name-criterion branch from b8a18a2 to eafbc5f Compare December 19, 2023 14:49
@ciastektk ciastektk requested a review from a team December 20, 2023 13:12
@ciastektk ciastektk added Feature New feature request Ready for review labels Dec 20, 2023
@konradoboza konradoboza requested a review from a team December 21, 2023 08:04
@ciastektk ciastektk requested a review from alongosz December 22, 2023 08:09
@ciastektk ciastektk force-pushed the ibx-7418-added-criterion-visitior-for-content-name-criterion branch from 8f3820e to 4979ddf Compare January 12, 2024 13:27
@alongosz alongosz requested a review from a team January 12, 2024 13:34
This was referenced Jan 12, 2024
Merged
Merged
tomaszszopinski
tomaszszopinski approved these changes Jan 17, 2024
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@ciastektk ciastektk force-pushed the ibx-7418-added-criterion-visitior-for-content-name-criterion branch from 4979ddf to 3d6f190 Compare January 17, 2024 13:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit 0be9b85 into main Jan 17, 2024
19 checks passed
@alongosz alongosz deleted the ibx-7418-added-criterion-visitior-for-content-name-criterion branch January 17, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@webhdx webhdx webhdx approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

Labels
Feature New feature request QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ciastektk @alongosz @webhdx @konradoboza @tomaszszopinski @Steveb-p