IBX-9444: Fixed locale ach-UG #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adamwojs
approved these changes
Jan 30, 2025
konradoboza
approved these changes
Jan 30, 2025
ViniTou
reviewed
Jan 31, 2025
| @@ -19,7 +19,7 @@ class AvailableLocaleChoiceLoader implements ChoiceLoaderInterface | |||
| { | |||
| // Acholi dialect is used by In-Context translation | |||
| // and should not be present on the list of available translations. | |||
| private const EXCLUDED_TRANSLATIONS = ['ach']; | |||
| private const EXCLUDED_TRANSLATIONS = ['ach-UG']; | |||
There was a problem hiding this comment.
Not sure how Crowdin does things here, but just to be sure, I would leave both values if that solves the issue.
@mikadamczyk, could you sheed some light on this as well.
There was a problem hiding this comment.
Hi @ViniTou ,
from what I see:
TranslationCollectorPassmaps some locales to languages, see
https://github.com/ibexa/core/blob/main/src/bundle/Core/DependencyInjection/Compiler/TranslationCollectorPass.php#L22- TranslationCollectorPass
calls https://github.com/ibexa/core/blob/main/src/bundle/Core/Translation/GlobCollector.php GlobCollectorchecks forxlffiles and extracts locales from filenames like
https://github.com/ibexa/i18n/blob/main/translations/ach_UG/activity-log/forms.**ach-UG**.xlf- So we will have ach-UG locale
There are several alternative options:
- Add mapping
ach-UG->achto TranslationCollectorPass. Then there is no need at all to change anything in ibexa/user bundle - Or ('better safe then sorry' approach) : add both strings to
EXCLUDED_TRANSLATIONS:
private const EXCLUDED_TRANSLATIONS = ['ach', 'ach-UG'];
There was a problem hiding this comment.
@reithor you are right, currently we have ach-UG as a locale and it should be
private const EXCLUDED_TRANSLATIONS = ['ach-UG']
The 'ach' version is only valid when someone adds it as a user_preferences.additional_translations which I bet will never happen
mikadamczyk
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I see we are not using the language
achanywhere - only the localeach-UG.PR excludes
ach-UGfrom choices list - and also changes AvailableLocaleChoiceLoaderTest.php accordingly.