Icp312

[dkleinfelder]

The version number of the images should probably be better in a variable using tfvars ...
instead of hard-coding the version in the bootstrap.sh script.

[jkwong888]

this was meant as a temporary filename and it didn't really matter what the version on this was as it would just extract whatever was in S3 and load it.

if you want, you can change this to ${IMAGE_DIR}/basename ${image_location}` so it just uses the filename of what was out there on s3. so we don't have to change the filenames every time there's a new release

[hassenius]

+1 to having those two lines say

${awscli} s3 cp ${image_location} ${IMAGE_DIR}/$(basename ${image_location})
tar zxf ${IMAGE_DIR}/$(basename ${image_location}) -O | docker load

Will both be more future proof and avoid confusion

[dkleinfelder]

Well, we had both in the bucket and it pulled 3.1.0 then.         Detlef Kleinfelder Consulting IT Specialist, Hybrid Cloud Lab Services API Management & Cloud Service Management and Operations IBM Deutschland GmbH Phone: 49-171-7663336 E-mail: [email protected]         Vorsitzender des Aufsichtsrats: Martin JetterGeschäftsführung: Matthias Hartmann (Vorsitzender), Norbert Janzen, Stefan Lutz, Nicole Reimer, Dr. Klaus Seifert, Wolfgang WendtSitz der Gesellschaft: Ehningen / Registergericht: Amtsgericht Stuttgart, HRB 14562 / WEEE-Reg.-Nr. DE 99369940         ----- Original message -----From: Jeffrey Kwong <[email protected]>To: ibm-cloud-architecture/terraform-icp-aws <[email protected]>Cc: dkleinfelder <[email protected]>, Author <[email protected]>Subject: Re: [ibm-cloud-architecture/terraform-icp-aws] Icp312 (#15)Date: Fri, Feb 22, 2019 3:17 PM  @jkwong888 commented on this pull request. In scripts/bootstrap.sh:

@@ -157,8 +157,8 @@ image_load() {       #TODO Is this install directory parameterized?       IMAGE_DIR=/opt/ibm/cluster/images       mkdir -p ${IMAGE_DIR}-      ${awscli} s3 cp ${image_location} ${IMAGE_DIR}/ibm-cloud-private-x86_64-3.1.0.tar.gz-      tar zxf ${IMAGE_DIR}/ibm-cloud-private-x86_64-3.1.0.tar.gz -O | docker load+      ${awscli} s3 cp ${image_location} ${IMAGE_DIR}/ibm-cloud-private-x86_64-3.1.2.tar.gz+      tar zxf ${IMAGE_DIR}/ibm-cloud-private-x86_64-3.1.2.tar.gz -O | docker load

this was meant as a temporary filename and it didn't really matter what the version on this was as it would just extract whatever was in S3 and load it. if you want, you can change this to ${IMAGE_DIR}/basename ${image_location}` so it just uses the filename of what was out there on s3. so we don't have to change the filenames every time there's a new release —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.  

[jkwong888]

you can still have both in the bucket but the variable image_location refers to the actual package you're downloading. what it saves the file to on the filesystem isn't really relevant as it just unzips it and docker loads it. i just want to avoid having to update this file every time there's a new ICP release because it doesn't affect functionality, just name of the file.