Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix logout compatibility with passport >= 0.6.0 #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix logout compatibility with passport >= 0.6.0 #305

wants to merge 1 commit into from

Conversation

gian1200
Copy link

@gian1200 gian1200 commented Oct 14, 2024 •
edited
Loading

Closes #306

Version 7.0.0 of appid-serversdk-nodejs started support of passport v0.6.0. However, logout function was missed in the upgrade.

From Passport CHANGELOG

req#logout() is now an asynchronous function and requires a callback function as the last argument.

This PR:

  • Add support for async req#logout()
  • Keep support for sync req#logout() (when older passport versions are used)
  • Add some tests
  • Update examples and Readme files
  • Clean up Readme.md a little bit (fix some markdownlint warnings)

@gian1200
fix(logout): fix logout compatibility with passport >= 0.6.0
7026d13 
- Starting passport 0.6.0, req#logout() is now an asynchronous function and adds a callback function as the last argument.
@gian1200 gian1200 mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue when logging out with passport 0.6.0 or greater
1 participant
@gian1200