Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load from LoRA on HF notebook #82

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Add load from LoRA on HF notebook #82

merged 2 commits into from
Nov 13, 2024

Conversation

rawkintrevo
Copy link
Contributor

PR Checklist

Notebook requirements

  • Notebook outputs cleared: Ensure all notebook outputs are cleared.
  • Test in Google Colab:
    • Test that it works in Google Colab (Python 3.10.12).
    • Colab has its own package set and Python version, so ensure compatibility.

Incoming References

  • README.md updates:
    • Add a link to the recipe in the Table of Contents (ToC).
    • Include a Colab button after that link.

GitHub

  • Commits signed: All commits must be GPG or SSH signed.
  • DCO Compliance: Developer Certificate of Origin (DCO) applies to the code, documentation, and any example data provided. Ensure commits are signed off.

@adampingel
Copy link
Contributor

We should group this recipe with the fine-tuning one in the ToC, but I can do that in a separate PR. (There's an existing story that I own covering this.)

@adampingel
Copy link
Contributor

Related to last comment: Let's adjust the intro language "We now demonstrate how to load a model back for inference." by adding a link to the previous recipe and reminding the reader of the context.

@adampingel
Copy link
Contributor

This recipe is testable. I happened to grant access to my HF_TOKEN during my run-through just now. Is that necessary? If so, we can get in available as an org-level secret.

I'm going to merge this as-is, but let's address the points in these 3 comments soon.

@adampingel adampingel merged commit 548d1b4 into main Nov 13, 2024
7 checks passed
@adampingel adampingel deleted the no-jira-load-lora branch November 13, 2024 15:38
@rawkintrevo
Copy link
Contributor Author

Agree on the cross links, my thought was get this one in, then link from the training notebook to this one, and this one back to the training one. The latter I could have done in this PR. (probably on the code one too).

On testable: I don't know if it is? In the test it will download and try to run the notebook. I don't know how that will work in a CPU only environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants