Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review semantics, implementation, and testing of methods in utils package #20

Open
adampingel opened this issue Oct 21, 2024 · 2 comments
Assignees

Comments

@adampingel
Copy link
Contributor

adampingel commented Oct 21, 2024

The utils.get_env_vars() function has the side-effect of setting the given variable in the environment. This is due to the fact that the Replicate client is not passing the api key through to later stages of processing. We would like to remove the side-effect.

Options:

  • Use set_env_var(get_env_var('VAR')) to set the variable before using the replicate client.
  • Fix the replicate client (contrib to langchain-community) to pass the api key through.
@adampingel adampingel converted this from a draft issue Oct 21, 2024
@adampingel adampingel mentioned this issue Oct 21, 2024
16 tasks
@adampingel
Copy link
Contributor Author

See discussion in #19

@adampingel adampingel changed the title review semantics and implementation of methods in utils package review semantics, implementation, and testing of methods in utils package Oct 22, 2024
@fayvor
Copy link
Contributor

fayvor commented Oct 24, 2024

See this issue for ways to get Replicate API Key to pass through.

@fayvor fayvor removed their assignment Oct 31, 2024
@adampingel adampingel moved this from In Current Milestone to Backlog in Granite Cookbooks Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants