-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up Summarize tests in CI #31
Conversation
Tests will fail until this is merged: |
recipes/Summarize/Summarize.ipynb
Outdated
"excerpt_length = 20000\n", | ||
"text = book_contents # [:excerpt_length]\n", | ||
"# Use entire book, or truncate if testing.\n", | ||
"text = book_contents if not get_env_var('GRANITE_TEST', 'false') == 'true' else book_contents[:20000]\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if get_env_var('GRANITE_TEST').lower() == 'true' book_contents[:20000]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the variable is GRANITE_TESTING
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agentic_RAG is failing trying to load langchain_ibm for WatsonxLLM. Not sure if this is deterministic, but I believe it has to do with the version of langchain-ibm that pip resolves to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will address @rawkintrevo's feedback in this ticket ibm-granite-community/utils#20
Signed-off-by: Fayvor Love <[email protected]>
0d66ad6
to
c620db7
Compare
Signed-off-by: Fayvor Love <[email protected]>
#149
PR Checklist
!pip install git+https://github.com/ibm-granite-community/granite-kitchen
in the instructions.