Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up Summarize tests in CI #31

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

fayvor
Copy link
Contributor

@fayvor fayvor commented Oct 21, 2024

#149

  • Truncate text in CI by looking at GRANITE_TEST env var

PR Checklist

  • Commits signed: All commits must be GPG or SSH signed.
  • DCO Compliance: Developer Certificate of Origin (DCO) applies to the code, documentation, and any example data provided. Ensure commits are signed off.
  • Notebook outputs cleared: Ensure all notebook outputs are cleared.
  • Automated testing: Add the recipe to the automated tests.
  • Test in Google Colab:
    • Test that it works in Google Colab (Python 3.10.12).
    • Colab has its own package set and Python version, so ensure compatibility.
  • Test locally:
    • Ensure the code works in a fresh Python virtual environment (venv).
  • Flexible LLM platform support:
    • The platform should be easily switchable. Use LangChain for now.
    • Include !pip install git+https://github.com/ibm-granite-community/granite-kitchen in the instructions.
  • Example data: Follow the example data guidance.
  • README.md updates:
    • Add a link to the recipe in the Table of Contents (ToC).
    • Include a Colab button after that link.

@fayvor fayvor requested a review from adampingel October 21, 2024 17:34
@fayvor
Copy link
Contributor Author

fayvor commented Oct 21, 2024

Tests will fail until this is merged:
ibm-granite-community/utils#19

"excerpt_length = 20000\n",
"text = book_contents # [:excerpt_length]\n",
"# Use entire book, or truncate if testing.\n",
"text = book_contents if not get_env_var('GRANITE_TEST', 'false') == 'true' else book_contents[:20000]\n",
Copy link
Contributor

@rawkintrevo rawkintrevo Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if get_env_var('GRANITE_TEST').lower() == 'true' book_contents[:20000]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the variable is GRANITE_TESTING

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update.

Copy link
Contributor Author

@fayvor fayvor Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agentic_RAG is failing trying to load langchain_ibm for WatsonxLLM. Not sure if this is deterministic, but I believe it has to do with the version of langchain-ibm that pip resolves to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will address @rawkintrevo's feedback in this ticket ibm-granite-community/utils#20

@fayvor fayvor force-pushed the 149-speed-up-summarize-test branch from 0d66ad6 to c620db7 Compare October 21, 2024 22:04
Signed-off-by: Fayvor Love <[email protected]>
@adampingel adampingel merged commit b959824 into main Oct 22, 2024
1 of 2 checks passed
@adampingel adampingel deleted the 149-speed-up-summarize-test branch October 22, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants