Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finetuning abstraction #246

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Finetuning abstraction #246

wants to merge 19 commits into from

Conversation

wgifford
Copy link
Collaborator

No description provided.

@wgifford wgifford requested a review from ssiegel95 as a code owner January 28, 2025 20:26
@ssiegel95
Copy link
Collaborator

ssiegel95 commented Jan 28, 2025

@wgifford I think you're going to need changes that are either on chronos_bolt or chronos_test_coverage (or both) to resolve the issue with test_model_lib.py. @gganapavarapu I sort of remember that one was merged onto the other, do you recall which?

Nope.

@gganapavarapu
Copy link
Collaborator

@ssiegel95 Merged commits for test_inference_lib.py are in these PRs: https://github.com/ibm-granite/granite-tsfm/pull/213/commits, https://github.com/ibm-granite/granite-tsfm/pull/217/commits.

Few errors I see in build failure seem to be from missing handler config in load() call:

handler, e = ForecastingServiceHandler.load(model_id=input_payload.model_id, model_path=model_path)
.

@wgifford wgifford marked this pull request as draft January 29, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants