fork and fix tsfm_public/version.py #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On cloning the repo and importing TimeSeriesPreprocessor at tsfm_public using
from tsfm_public.toolkit.time_series_preprocessor import TimeSeriesPreprocessor
to create a new data loader, I got the following error
Traceback (most recent call last):
File "/dccstor/iloum-la/expts_notebooks/tsfm/data/new_datasets.py", line 11, in
from tsfm_public.toolkit.time_series_preprocessor import TimeSeriesPreprocessor
File "/dccstor/iloum-la/expts_notebooks/granite-tsfm/tsfm_public/init.py", line 4, in
from .version import version, version_tuple
ImportError: cannot import name 'version_tuple' from 'tsfm_public.version' (/dccstor/iloum-la/expts_notebooks/granite-tsfm/tsfm_public/version.py)
Looks like there is a bug in version.py. Changing the version.py in the below manner resolved the error.
try:
# Local
from ._version import __version__, __version_tuple__ # noqa: F401 # unused import
except ImportError:
__version__ = "unknown"
version_tuple = (0, 0, __version__) ##### earlier line
__version_tuple__ = (0, 0, __version__) #### our change
fixes to tsfm_public/version.py
wgifford
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On cloning the repo and importing TimeSeriesPreprocessor at tsfm_public using
from tsfm_public.toolkit.time_series_preprocessor import TimeSeriesPreprocessor
to create a new data loader, I got the following error
Traceback (most recent call last):
File "/dccstor/iloum-la/expts_notebooks/tsfm/data/new_datasets.py", line 11, in
from tsfm_public.toolkit.time_series_preprocessor import TimeSeriesPreprocessor
File "/dccstor/iloum-la/expts_notebooks/granite-tsfm/tsfm_public/init.py", line 4, in
from .version import version, version_tuple
ImportError: cannot import name 'version_tuple' from 'tsfm_public.version' (/dccstor/iloum-la/expts_notebooks/granite-tsfm/tsfm_public/version.py)
Looks like there is a bug in version.py. Changing the version.py in the below manner resolved the error.