Bug Fix - NullPointerException in Kafka Connect Pipeline when JMS Property Key is Empty #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…operties, the kafka connect pipeline is failing with NullpointerException while sinking the data to kafka . This scenario is handled in try block in the JmsToKafkaHeaderConverter class
balajisekarraman
changed the title
1 task
| @@ -48,7 +48,13 @@ public ConnectHeaders convertJmsPropertiesToKafkaHeaders(final Message message) | |||
|
|
|||
| jmsPropertyKeys.forEach(key -> { | |||
| try { | |||
| connectHeaders.addString(key.toString(), message.getObjectProperty(key.toString()).toString()); | |||
| String value = ""; | |||
| if (message.getObjectProperty(key.toString()) != null) | |||
There was a problem hiding this comment.
Nit comment: you can extract message.getObjectProperty(key.toString()) to a value and refer to both the places.
| value = message.getObjectProperty(key.toString()).toString(); | ||
| } | ||
| connectHeaders.addString(key.toString(), value); | ||
| //connectHeaders.addString(key.toString(), message.getObjectProperty(key.toString()).toString()); |
There was a problem hiding this comment.
Nit comment: Remove the commented line. It is not needed.
| @@ -48,7 +48,13 @@ public ConnectHeaders convertJmsPropertiesToKafkaHeaders(final Message message) | |||
|
|
|||
| jmsPropertyKeys.forEach(key -> { | |||
| try { | |||
| connectHeaders.addString(key.toString(), message.getObjectProperty(key.toString()).toString()); | |||
| String value = ""; | |||
There was a problem hiding this comment.
should we add empty value or null ?
|
|
||
| // Act | ||
| final ConnectHeaders actualConnectHeaders = jmsToKafkaHeaderConverter | ||
| .convertJmsPropertiesToKafkaHeaders(message); | ||
|
|
||
|
|
||
| //Verify | ||
| assertEquals("Both custom JMS properties were copied to kafka successfully.", 2, actualConnectHeaders.size()); | ||
| assertEquals("Both custom JMS properties were copied to kafka successfully.", 3, actualConnectHeaders.size()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MQ, if the value for any of the JMS property keys is empty, and we set the property mq.jms.properties.copy.to.kafka.headers = true in our connector properties, the Kafka Connect pipeline fails with a "NullPointerException" while attaching those properties in my kafka headers , As a result, the messages are routed to the BO queue.
Type of issue - Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested? - YES
Tried setting the flag as false for mq.jms.properties.copy.to.kafka.headers and there are no exception but the properties from my MQ is not attached to my kafka headers
Handled the scneario in the jmsToKafkaHeaderConverter class , where is the value for a key is empty/null then we are passing the value for that particular key as a empty string "" , by doing this the messages are not moving to BO queue and my kafka connect pipeline is running without any exception
Checklist