-
Notifications
You must be signed in to change notification settings - Fork 114
Correct key widths #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MiniGod
wants to merge
3
commits into
icebob:master
Choose a base branch
from
MiniGod:correct-key-widths
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Could you show screenshot about differences, I mean how it looks before & after PR. |
b0e388b
to
c3afd0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently issue: When giving keys a custom size it can be hard to make them align correctly with the other lines, and the math doesn't add up. For instance, in the page running in
npm run dev
, the0
key for the numeric input is supposed to be 3x as big as a normal key. A normal keyflex: 40
, so logically, the0
key should be{ size: 40 * 3 }
, but then it is too small so it is set to130
. This is caused by themargin
s mixed with flex.This PR fixes this so that the keys align correctly, and the math adds up. It is mostly just code around, and had to wrap all keys in another
div
.I tried to keep the diff clean, but I had to indent so I suggest you look at the diff with "No Whitespace" enabled.