-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Installation Easier #413
Conversation
This reverts commit 2ad3e28.
That is a good idea, I had suggested it when In principle the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My only comment is that we should either both test and build for python 3.9 or if we do not build that version then there is also no need to test it.
@mlincett do you want me to move it back to the github action black? My thinking was that the new setup is cleaner, since there is exactly one thing pinned ( |
Sorry, I thought I had answered but it was just a draft in my mind. As we have a setup that works, no need to overthink at the moment. |
I often use
flarestack
downstream as a dependency, and noticed that it has become harder to install.This PR converts photospline to an optional dependency (you only get the import error when you actually try and use photosopline).
It also does a couple of other quality of life bug fixes:
black
2024 #347)python 3.13 is still too hard because of #270, but once that's fixed you can bump scipy to a higher version and add python 3.13 support.