Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Installation Easier #413

Merged
merged 22 commits into from
Jan 29, 2025
Merged

Make Installation Easier #413

merged 22 commits into from
Jan 29, 2025

Conversation

robertdstein
Copy link
Member

I often use flarestack downstream as a dependency, and noticed that it has become harder to install.

This PR converts photospline to an optional dependency (you only get the import error when you actually try and use photosopline).

It also does a couple of other quality of life bug fixes:

  • Splits off black into a separate CI test, and tests black using pinned local version, and moves the black version to "dev" dependency in pyproject.toml (fix use black 2024 #347)
  • Adds support for python 3.12 (after bumping photospline version)

python 3.13 is still too hard because of #270, but once that's fixed you can bump scipy to a higher version and add python 3.13 support.

@mlincett
Copy link
Collaborator

That is a good idea, I had suggested it when photospline was added as dependency.

In principle the psf/black action can read the version from pyproject.toml so it should not be necessary to use the workaround we have in place.

Copy link
Collaborator

@JannisNe JannisNe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only comment is that we should either both test and build for python 3.9 or if we do not build that version then there is also no need to test it.

.github/workflows/continous_integration.yml Outdated Show resolved Hide resolved
@robertdstein
Copy link
Member Author

@mlincett do you want me to move it back to the github action black? My thinking was that the new setup is cleaner, since there is exactly one thing pinned (black python version), and any changes are automatically bumped by dependabot. It's a also cleaner template to add in other auto-linting e.g isort. But if you prefer the old method I can do that.

@robertdstein robertdstein requested a review from JannisNe January 27, 2025 15:42
@mlincett
Copy link
Collaborator

@mlincett do you want me to move it back to the github action black? My thinking was that the new setup is cleaner, since there is exactly one thing pinned (black python version), and any changes are automatically bumped by dependabot. It's a also cleaner template to add in other auto-linting e.g isort. But if you prefer the old method I can do that.

Sorry, I thought I had answered but it was just a draft in my mind. As we have a setup that works, no need to overthink at the moment.

@robertdstein robertdstein merged commit fbc6a80 into master Jan 29, 2025
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use black 2024
3 participants