Update 4FGL-DR4 Source List #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ric-evans
reviewed
Feb 10, 2025
Comment on lines
259
to
262
| return Affine2D() \ | ||
| .scale(0.5 / xscale, 0.5 / yscale) \ | ||
| .translate(0.5, 0.5) No newline at end of file | ||
| .translate(0.5, 0.5) |
There was a problem hiding this comment.
I don't like the \-syntax to split between lines. If it doesn't all fit on one line, I recommend taking a look at how the black formatter does this: https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#call-chains
ric-evans
reviewed
Feb 10, 2025
| @@ -121,7 +121,7 @@ def plot_catalog(master_map, cmap, lower_ra, upper_ra, lower_dec, upper_dec, | |||
| cmap_min=0., cmap_max=250.): | |||
| """"Plots the 4FGL catalog in a color that contrasts with the background | |||
| healpix map.""" | |||
| hdu = pyfits.open('/cvmfs/icecube.opensciencegrid.org/users/azegarelli/realtime/catalogs/gll_psc_v34.fit') ## LAT 14-year Source Catalog (4FGL-DR4 in FITS format) ; https://fermi.gsfc.nasa.gov/ssc/data/access/lat/14yr_catalog/') | |||
| hdu = pyfits.open('/cvmfs/icecube.opensciencegrid.org/users/azegarelli/realtime/catalogs/gll_psc_v35.fit') ## LAT 14-year Source Catalog (4FGL-DR4 in FITS format) ; https://fermi.gsfc.nasa.gov/ssc/data/access/lat/14yr_catalog/') | |||
There was a problem hiding this comment.
I recommend putting this path as a constant variable either at the top of this file, or in new file called config.py/constants.py/etc. This way, constant values can be easily found/tracked in the future.
G-Sommani
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request aims to use the most up-to-date .fit file provided by the Fermi collaboration for the LAT 14-year Source Catalog when generating skymap plots.