Remove zbus
dependency in dark-light
#2624
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should wait for upstream to see what happens with the pull request: rust-dark-light/dark-light#40 (it also needs testing on macOS and windows).
Should I add a
auto-detect-theme-zbus
feature that activateszbus
feature indark-light
? Afaik there's no other way fordark-light
to know ifzbus
is used. The portal (which is the only usage ofzbus
) is only used as a fallback after DE specific methods, and this PR doesn't add support for thesubscribe
method that gives you a stream of theme yet (which does relay directly on portals and thuszbus
), so it should very rarely be used anyway.