Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "outer" positions in all window-related operations #2688

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Dec 6, 2024

@hecrj hecrj added bug Something isn't working shell fix labels Dec 6, 2024
@hecrj hecrj added this to the 0.14 milestone Dec 6, 2024
@hecrj hecrj force-pushed the fix/window-position-inconsistency branch from 69b4021 to 169e5fc Compare December 6, 2024 03:35
@SoulSharer
Copy link

Thanks for the fix! We also need to correct comments for window events:

core\src\window\event.rs:

  /// A window was opened.
    Opened {
        /// The position of the opened window. This is relative to the top-left corner of the desktop
        /// the window is on, including virtual desktops. Refers to window's "outer" position,
        /// or the window area, in logical pixels.
        ///
        /// **Note**: Not available in Wayland.
        position: Option<Point>,
        /// The size of the created window. This is its "inner" size, or the size of the
        /// client area, in logical pixels.
        size: Size,
    },

Now I'm also wondering whether we should provide "outer" size for Opened event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix shell
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants