-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more syntax languages and themes #2822
base: master
Are you sure you want to change the base?
Conversation
6067027
to
35277ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few suggestions, but nothing too major
daa129b
to
34ecbfb
Compare
Got a couple of commit suggestions that you can cherry-pick if you want
|
add more syntec themes update rfd clippy clippy 2 suggestions and removed syntect in favor of two-face export of syntect removed comment forgot the other cargo.toml :P Bring back base16 highlighter themes (cherry picked from commit 127bd0a) Switch LazyThemeSet to EmbeddedLazyThemeSet (cherry picked from commit 0045223)
bcd1650
to
da78292
Compare
genius code, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything's all good now from my side 👍
This pr uses the two face crate which just bundles syntect and the themes used by bat. All themes were tested using the editor example and the extra languages were testing with
.toml
and.nix
files which are not included by syntect, overall adding support for common use cases.Let me know what you would suggest about the themes that don't display properly, I left comment notes by them but I can just delete them.