Allow xmp sidecar plists in XML format #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add tests for files with plist in xml format, pls? |
@euank any chance you can add tests soon, so we can merge the fix? |
|
Will do! Apologies for the slow response, I've been off on vacation, but I'll get to it either this evening, or this weekend |
Some older files seem to use that format. I have a file from early 2020 in my iCloud which has an XML plist, so it seems plausible apple used to upload them in that format? I obviously don't remember how I actually added that file or when exactly, but you know, it's there. Fixes icloud-photos-downloader#1059 I've also run ./scripts/format and added a unit test
|
Updated the unit tests to include the data that originally errored out, hopefully that level of testing makes sense to you! |
AndreyNikiforov
merged commit 9c88079
into
icloud-photos-downloader:master
372 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some older files seem to use that format.
I have a file from early 2020 in my iCloud which has an XML plist, so it seems plausible apple used to upload them in that format?
I obviously don't remember how I actually added that file or when exactly, but you know, it's there.
Fixes #1059