Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bts): unit tests solidity bts #599

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

sdpisreddevil
Copy link
Collaborator

@sdpisreddevil sdpisreddevil commented Oct 12, 2022

Closes #598

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

@sdpisreddevil sdpisreddevil changed the title Feat/add bts unit tests solidity feat(bts): unit tests solidity bts Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #599 (4c94bb0) into main (10d00dd) will increase coverage by 8.52%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #599      +/-   ##
============================================
+ Coverage     38.31%   46.84%   +8.52%     
  Complexity      700      700              
============================================
  Files           109       98      -11     
  Lines         10263     9338     -925     
  Branches        941      745     -196     
============================================
+ Hits           3932     4374     +442     
+ Misses         6007     4627    -1380     
- Partials        324      337      +13     
Impacted Files Coverage Δ
solidity/bts/contracts/test/BMC.sol 54.16% <ø> (+54.16%) ⬆️
cmd/iconbridge/chain/bsc/client.go 62.87% <0.00%> (-1.52%) ⬇️
solidity/bts/contracts/libraries/DecodeBase64.sol
solidity/bts/contracts/test/NonRefundable.sol
solidity/bts/contracts/BTSCoreV1.sol
solidity/bts/contracts/libraries/EncodeBase64.sol
...lidity/bts/contracts/libraries/RLPDecodeStruct.sol
...lidity/bts/contracts/libraries/RLPEncodeStruct.sol
solidity/bts/contracts/BTSCoreV2.sol
solidity/bts/contracts/test/Holder.sol
... and 13 more

@izyak
Copy link
Collaborator

izyak commented Oct 15, 2022

Remove the doc folder which has empty markdown file.
Remove empty files ocs/icon/bmc.md, docs/bsc/bmc.md.

@andrii-kl
Copy link
Collaborator

Remove the doc folder which has empty markdown file. Remove empty files ocs/icon/bmc.md, docs/bsc/bmc.md.

@sdpisreddevil

@andrii-kl
Copy link
Collaborator

Why we commented so many test cases in the next files, the one file was fully commented?
solidity/bts/test/integration/1-upgradeability-native-coin-bts.js
solidity/bts/test/integration/2-native-coin-bts.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants