Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: icon bridge migration #872

Merged
merged 6 commits into from
Apr 25, 2024
Merged

feat: icon bridge migration #872

merged 6 commits into from
Apr 25, 2024

Conversation

izyak
Copy link
Collaborator

@izyak izyak commented Apr 18, 2024

Closes #ISSUE-NUMBER

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@izyak izyak requested a review from sdpisreddevil as a code owner April 18, 2024 01:12
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 3.03030% with 192 lines in your changes are missing coverage. Please review.

Project coverage is 33.45%. Comparing base (43e7ce3) to head (244cea6).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #872      +/-   ##
============================================
- Coverage     36.39%   33.45%   -2.94%     
+ Complexity      811      748      -63     
============================================
  Files           125      127       +2     
  Lines         12061    12458     +397     
  Branches       1091     1216     +125     
============================================
- Hits           4389     4168     -221     
- Misses         7332     7953     +621     
+ Partials        340      337       -3     
Files Coverage Δ
solidity/bts/contracts/BTSCore.sol 8.37% <0.00%> (+0.12%) ⬆️
.../java/foundation/icon/btp/bts/BTPTokenService.java 57.50% <31.57%> (-25.48%) ⬇️
solidity/bts/contracts/BTSCoreV5.sol 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@CyrusVorwald CyrusVorwald merged commit 71b8210 into main Apr 25, 2024
8 of 9 checks passed
@CyrusVorwald CyrusVorwald deleted the feat/icon-bridge-migration branch April 25, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants