-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: solana intent contract #12
base: main
Are you sure you want to change the base?
Conversation
f5e03c2
to
79fefb7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
============================================
- Coverage 89.62% 89.51% -0.12%
Complexity 77 77
============================================
Files 39 39
Lines 2275 2307 +32
Branches 37 37
============================================
+ Hits 2039 2065 +26
- Misses 219 225 +6
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. |
79fefb7
to
52d57dc
Compare
52d57dc
to
1c1c081
Compare
src_network: String, | ||
fill: Option<OrderFill>, | ||
cancel: Option<Cancel>, | ||
order: SwapOrder, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of doing optional Cancel and Fill , better way would be to declare enum that has either fill or cancel data because they are mutually exclusive options. That way you can just do match on invoke resolve without any worry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few changes for readability else looks good.
Description:
Commit Message
see the guidelines for commit messages.
Changelog Entry
Checklist: