Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solana intent contract #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bishalbikram
Copy link

Description:

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@bishalbikram bishalbikram self-assigned this Dec 12, 2024
@bishalbikram bishalbikram force-pushed the feat/solana-intent-contract branch from f5e03c2 to 79fefb7 Compare December 17, 2024 07:39
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (c7dae72) to head (1c1c081).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #12      +/-   ##
============================================
- Coverage     89.62%   89.51%   -0.12%     
  Complexity       77       77              
============================================
  Files            39       39              
  Lines          2275     2307      +32     
  Branches         37       37              
============================================
+ Hits           2039     2065      +26     
- Misses          219      225       +6     
  Partials         17       17              
Flag Coverage Δ
solidity 86.11% <ø> (-1.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@bishalbikram bishalbikram force-pushed the feat/solana-intent-contract branch from 79fefb7 to 52d57dc Compare December 18, 2024 03:13
@bishalbikram bishalbikram force-pushed the feat/solana-intent-contract branch from 52d57dc to 1c1c081 Compare December 30, 2024 05:37
src_network: String,
fill: Option<OrderFill>,
cancel: Option<Cancel>,
order: SwapOrder,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of doing optional Cancel and Fill , better way would be to declare enum that has either fill or cancel data because they are mutually exclusive options. That way you can just do match on invoke resolve without any worry.

Copy link
Collaborator

@ibrizsabin ibrizsabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few changes for readability else looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants