Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Mermaid HTML diagrammer from input assembly via ilspycmd #3324

Merged
merged 22 commits into from
Nov 15, 2024

Conversation

h0lg
Copy link
Contributor

@h0lg h0lg commented Nov 8, 2024

In this PR I contribute https://github.com/h0lg/netAmermaid to ILSpy - building it into ILSpyX and making it accessible via ilspycmd as discussed in h0lg/netAmermaid#6 .

Including a

@h0lg h0lg marked this pull request as draft November 8, 2024 00:53
@christophwille
Copy link
Member

Regarding documentation - I would propose:

  • add a separate section in https://github.com/icsharpcode/ILSpy/tree/master/ICSharpCode.ILSpyCmd (README.md) "Diagramming" with common command line samples and basic usage. Reference the wiki for
  • Deep-dive "how-to-use" in the Wiki
  • Deep-dive "developers working on the feature" info can go in a README inside the MermaidDiagrammer folder (exclude from build, no images)

@christophwille
Copy link
Member

Some general notes

@h0lg
Copy link
Contributor Author

h0lg commented Nov 8, 2024

0_o wow. I never worked in a repo where you get punished that hard for simple committing. Is there another way I can apply these formattings, e.g. pre-push? This is poison to my flow.

@christophwille
Copy link
Member

@h0lg
Copy link
Contributor Author

h0lg commented Nov 8, 2024

I am using https://marketplace.visualstudio.com/items?itemName=mynkow.FormatdocumentonSave

If that's all the script does - I have an extension like that running as well. I also found https://github.com/icsharpcode/ILSpy/blob/master/BuildTools/format.bat which seems to work if I replace the bash path to match my environment.

@h0lg h0lg force-pushed the mermaid-diagrammer branch 4 times, most recently from f40934c to 96fcf14 Compare November 8, 2024 20:27
@h0lg h0lg changed the title WIP: Generate Mermaid HTML diagrammer from input assembly via ilspycmd Generate Mermaid HTML diagrammer from input assembly via ilspycmd Nov 14, 2024
@h0lg h0lg marked this pull request as ready for review November 14, 2024 19:55
@christophwille christophwille merged commit 09ed31d into icsharpcode:master Nov 15, 2024
5 checks passed
@christophwille
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants