Suppress some localization related code analyzer suggestions #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #633 +/- ##
==========================================
+ Coverage 71.89% 71.93% +0.03%
==========================================
Files 62 62
Lines 7667 7667
==========================================
+ Hits 5512 5515 +3
+ Misses 2155 2152 -3
Continue to review full report at Codecov.
|
piksel
reviewed
May 12, 2021
Comment on lines
+47
to
+54
| # CA1305: Specify IFormatProvider | ||
| dotnet_diagnostic.CA1305.severity = none | ||
|
|
||
| # CA1304: Specify CultureInfo | ||
| dotnet_diagnostic.CA1304.severity = none | ||
|
|
||
| # CA1307: Specify StringComparison for clarity | ||
| dotnet_diagnostic.CA1307.severity = none |
There was a problem hiding this comment.
I'm not too sure about these... They might still lead to some unwanted behaviour when running in various non-english environments...
It would probably be better to actually fix these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin off from #449 that disables some of the localization related analyzers, to decide if disabling the set is ok (for now at least)
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.