style: improvements to tabs, course/added panes (#1131)

icssc · Jan 28, 2025 · 70e13bb · 70e13bb
1 parent afbc80e
commit 70e13bb
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/apps/antalmanac/src/components/RightPane/AddedCourses/AddedCoursePane.tsx b/apps/antalmanac/src/components/RightPane/AddedCourses/AddedCoursePane.tsx
@@ -336,7 +336,7 @@ function AddedSectionsGrid() {
                 <ClearScheduleButton buttonSx={buttonSx} />
                 <ColumnToggleDropdown />
             </Box>
-            <Box style={{ marginTop: 50 }}>
+            <Box style={{ marginTop: 56 }}>
                 <Typography variant="h6">{`${scheduleName} (${scheduleUnits} Units)`}</Typography>
                 {courses.length < 1 ? NoCoursesBox : null}
                 <Box display="flex" flexDirection="column" gap={1}>

diff --git a/apps/antalmanac/src/components/RightPane/CoursePane/CoursePaneButtonRow.tsx b/apps/antalmanac/src/components/RightPane/CoursePane/CoursePaneButtonRow.tsx
@@ -154,7 +154,6 @@ export function CoursePaneButtonRow(props: CoursePaneButtonRowProps) {
                 display: props.showSearch ? 'block' : 'none',
                 width: '100%',
                 zIndex: 3,
-                marginBottom: 8,
                 position: 'absolute',
             }}
         >

diff --git a/apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx b/apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx
@@ -179,7 +179,6 @@ const ErrorMessage = () => {
             sx={{
                 height: '100%',
                 display: 'flex',
-                justifyContent: 'center',
                 alignItems: 'center',
                 flexDirection: 'column',
             }}
@@ -321,6 +320,8 @@ export default function CourseRenderPane(props: { id?: number }) {
 
     return (
         <>
+            <Box sx={{ height: '56px' }} />
+
             {loading ? (
                 <LoadingMessage />
             ) : error || courseData.length === 0 ? (
@@ -329,7 +330,6 @@ export default function CourseRenderPane(props: { id?: number }) {
                 <>
                     <RecruitmentBanner />
                     <Box>
-                        <Box sx={{ height: '50px', marginBottom: '5px' }} />
                         {courseData.map((_: WebsocSchool | WebsocDepartment | AACourse, index: number) => {
                             let heightEstimate = 200;
                             if ((courseData[index] as AACourse).sections !== undefined)

diff --git a/apps/antalmanac/src/components/ScheduleManagement/ScheduleManagementTab.tsx b/apps/antalmanac/src/components/ScheduleManagement/ScheduleManagementTab.tsx
@@ -28,15 +28,19 @@ export const ScheduleManagementTab = ({ tab, value }: ScheduleManagementTabProps
             icon={tab.icon}
             iconPosition={isMobile ? 'top' : 'start'}
             sx={{
-                ...(!isMobile
+                ...(isMobile
                     ? {
+                          minHeight: 'unset',
+                          minWidth: '25%',
+                          height: 56,
+                      }
+                    : {
                           minHeight: 'auto',
                           height: '44px',
                           padding: 3,
                           minWidth: '33%',
-                      }
-                    : { minWidth: '25%' }),
-                display: !isMobile && tab.mobile ? 'none' : 'flex',
+                      }),
+                display: isMobile || !tab.mobile ? 'flex' : 'none',
                 ...(isDark ? { '&.Mui-selected': { color: 'white' } } : {}),
             }}
             label={tab.label}