Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: exclude restriction codes #1033

Merged
merged 10 commits into from
Nov 18, 2024
Merged

feat: exclude restriction codes #1033

merged 10 commits into from
Nov 18, 2024

Conversation

KevinWu098
Copy link
Member

Summary

  1. Implements Anteater API's exclude restriction codes parameter into our Advanced Search

chrome-capture-2024-10-14

Test Plan

  1. Test that a singular code is filtered
  2. Test that multiple codes are excluded (OR)
  3. Test that the URL encoding works (both read/write)

Issues

Closes #595

MinhxNguyen7
MinhxNguyen7 requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selections should be more highlighted. Otherwise, looks fine

@KevinWu098
Copy link
Member Author

The selections should be more highlighted. Otherwise, looks fine

Screenshot 2024-11-14 at 3 49 46 PM Screenshot 2024-11-14 at 3 49 37 PM

Updated the look

MinhxNguyen7
MinhxNguyen7 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MinhxNguyen7 MinhxNguyen7 merged commit c2f7d35 into main Nov 18, 2024
4 checks passed
@smalldrew
Copy link

LGTM as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinhxNguyen7 MinhxNguyen7 MinhxNguyen7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter out major/school restrictions
3 participants
@KevinWu098 @smalldrew @MinhxNguyen7