Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent course info bar overflow #1042

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

andrew-wang0
Copy link
Member

@andrew-wang0 andrew-wang0 commented Nov 20, 2024

Summary

Prevent overflow
Screenshot_20241124-215015.png

Test Plan

Issues

Closes #729

Future Followup

will not be addressing

@KevinWu098 KevinWu098 requested review from KevinWu098 and removed request for MinhxNguyen7 November 20, 2024 05:14
Copy link
Member

@KevinWu098 KevinWu098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Really looking forward to the UI improvement via reduction of UI shift.

Have a couple comments/nits to resolve, but otherwise, looks solid!

Copy link
Member Author

@andrew-wang0 andrew-wang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@KevinWu098 KevinWu098 requested review from KevinWu098 and removed request for KevinWu098 November 21, 2024 03:47
@KevinWu098 KevinWu098 merged commit 491e473 into icssc:main Nov 21, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent Text-Wrap in SectionTableBody and the Department Card Component
3 participants