Restyled custom events modal #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed spacing and layout of event modal
|
@xgraceyan this looks ready for review. Is it? If not, no problem. Was just wondering. |
|
Yes, it's ready for review! Sorry, I forgot to change the status of the PR from a draft. |
|
I'll just comment that the "Issues" section in the PR description is for related GitHub issues. Issues with the PR itself should go in the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed spacing and layout of event modal (Changed modal -> Previous modal)
Fixed responsive issue with day selector when using mobile view (After - Before)
Test Plan
Make sure modal works properly and there are no visual issues on any viewport
Issues
Building search variant is not consistent with the other inputs (filled vs. outlined); however, the filled version of building select looks better in its other appearance in the map view
Perhaps we could pass the variant as props to the component so the building select can be outlined in the custom events modal while also filled in the map view?
Closes #1025