Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle inconsistent ge param #1045

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: handle inconsistent ge param #1045

merged 1 commit into from
Nov 21, 2024

Conversation

KevinWu098
Copy link
Member

Summary

  1. GE param would be referenced by ge or GE rather inconsistently in our URL parameter code. This PR resolves inconsistencies by making the GE URL param always ge.

Test Plan

  1. Test that searching by GE still works
  2. Test that loading a URL with a GE param still works
  3. Test that resetting search form clears GE

Issues

Closes #

adcockdalton
adcockdalton approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@adcockdalton adcockdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

followed test plan smoothly, works

did a case-sensitive ctrl+f in the AA repo to check for any stragglers and there were none

lgtm

@adcockdalton adcockdalton merged commit 2572fac into main Nov 21, 2024
5 checks passed
@adcockdalton adcockdalton deleted the kwu/fix-ge-param branch November 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adcockdalton adcockdalton adcockdalton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinWu098 @adcockdalton