-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate calendar #1048
Duplicate calendar #1048
Conversation
While you're here, can you replace the dropdown with a list of buttons? There's no reason to select, then having to press a button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on your first PR! Looks solid, barring one issue I've noted below.
Update: discussed with AA team to prioritize a simpler and more familiar duplication functionality (e.g. Make a Copy from Google Docs). The copy schedule modal is now only going to allow the making of duplicate schedules, removing "Copy to All Schedules" and "Copy to Schedule". |
Currently when the user tries to duplicate a schedule, a unique schedule name is enforced upon schedule creation, even if what they enter already exists. For example, if Winter-2025 exists, and a schedule tries to be duplicated with the name Winter-2025, a number (e.g. (1)) will be appended to the schedule name upon creation. However, users are still able to have schedule with duplicate names in these cases:
To help migrate towards a system where all schedule names are unique, we should enforce the same naming validation in the duplicate schedule feature for 2 and 3 (renaming and creating schedules). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
2 non-blocking questions for you, but otherwise, it looks good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this breaks prod, I blame @KevinWu098
Summary
Test Plan
Issues
Closes #1034, #1032