Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update error page #1057

Merged
merged 4 commits into from
Nov 26, 2024
Merged

feat: update error page #1057

merged 4 commits into from
Nov 26, 2024

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Nov 24, 2024

Summary

  1. Restyles error page for mobile
  2. Updates error display to use an Accordion
  3. Display current route
Screenshot 2024-11-24 at 8 13 06 AM Screenshot 2024-11-24 at 8 18 33 AM Screenshot 2024-11-24 at 8 13 52 AM Screenshot 2024-11-24 at 8 15 37 AM

Test Plan

  1. throw an Error somewhere, somehow (easiest may be to pull locally and manually throw)
  2. Check error page on desktop, confirming readability and that error is displayed by default
  3. Check error page on mobile, same considerations as desktop (especially responsiveness & readability)
  4. Check error page on light and dark mode

Issues

Follows up #968 and #1035

(I should've caught this originally on #1035, that's my bad)

Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems about right

@MinhxNguyen7 MinhxNguyen7 merged commit 818b168 into main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants