-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read from RDS #1060
Merged
Merged
Read from RDS #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
MinhxNguyen7
force-pushed
the
migrate-read
branch
from
November 25, 2024 23:39
6ca5411
to
e8d5c8e
Compare
MinhxNguyen7
force-pushed
the
migrate-read
branch
from
November 25, 2024 23:50
e8d5c8e
to
bce0d81
Compare
Code looks clean. Checking on staging now. |
adcockdalton
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Plan
- Create a schedule and add a section to it.
- Create another schedule and add a different section as well as a custom event.
- Save the user data.
- Clear the site data and reload the page.
- Load the previously-saved user.
- Verify that the previously-added data populates, and the order of schedules is correct.
- Delete a schedule, and repeat the reloading and verification procedures.
Additionally: - Create an additional user and mimic the prior process
- Confirm that a 7-day custom event has intended behavior
- Ensure that all facets of data persist for custom events (color, map location)
- Ensure that "remember me" has intended functionality when using multiple users
Looks good to me. What an exciting PR! Cheers
KevinWu098
reviewed
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
ScheduleSaveState
schema and making sure that we test the read and writeof every attribute.
Test Plan
Issues
Future Follow-Up