-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize app by reducing rerenders #1074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinhxNguyen7
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor gripes
apps/antalmanac/src/components/RightPane/AddedCourses/CustomEventDetailView.tsx
Outdated
Show resolved
Hide resolved
.../components/Calendar/toolbar/schedule-select/schedule-select-buttons/add-schedule-button.tsx
Outdated
Show resolved
Hide resolved
MinhxNguyen7
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems alright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using react-scan, we can identify areas with high rerenders and optimize AntAlmanac's performance. This PR targets three areas:
SectionTableBody
andHoveredStore
to remove unnecessary rerenders when hovering coursesCalendarRoot
to stop rerenders when interacting with calendar event elementsSectionTableBody
and adding courses, to remove renders caused by adding coursesBefore
SectionTableBody (hovering)
Calendar
SectionTableBody (adding courses)
After
SectionTableBody (hovering)
Note: the key thing is that
SectionTableBody
now does not rerender rows -- the calendar is expected to rerender (although it would be preferable if the entire thing didn't rerender, but that's a library level problem)Calendar
SectionTableBody (adding courses)
Test Plan
ScheduleConflict
(the darker highlighting of courses when it would overlight another course) should update correctly. The yellow highlighting should also update correctly. There should be no rerenders except for courses which overlap the newly added course.Note: React Scan should only be added to our dev environments (this includes staging), but it should not be added to prod