Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search course info button #1082

Merged
merged 6 commits into from
Dec 22, 2024
Merged

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Dec 22, 2024

Summary

  1. Adds a Button to the Course Info Toolbar which routes them to the corresponding search result for that course (all lectures, discussions, etc)

chrome-capture-2024-11-22

Test Plan

  1. The button should only show on the added pane
  2. Clicking the button should route to the correct search, with the correct URL parameters set (term, deptValue, courseNumber)

Issues

From feedback:

When making my schedule I like to go in two rounds. First, I select all the lectures I will be attending, but not the labs/discussions. Then on the second round I go back and add in the best timing of discussions/labs. In your app it is difficult to do this because there is no button that lets you immediately jump from the lecture to then seeing all of the associated discussions with that lecture, instead, I have to manually search up the name of the class.

Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice feature

@MinhxNguyen7 MinhxNguyen7 merged commit 5c5ab75 into main Dec 22, 2024
3 of 4 checks passed
@MinhxNguyen7 MinhxNguyen7 deleted the kwu/search-course-info-button branch December 22, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🤩
Development

Successfully merging this pull request may close these issues.

2 participants