Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade tsx #1084

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

deps: upgrade tsx #1084

wants to merge 1 commit into from

Conversation

KevinWu098
Copy link
Member

Summary

  1. Upgrades tsx dependency, resolving a breaking change in Node which broke older versions of tsx

See: nodejs/node#51048 (comment)

Test Plan

  1. Tests and deployment should run as expected

Issues

Closes #1081 #1070

@KevinWu098
Copy link
Member Author

@MinhxNguyen7 gonna need a key to be added to our secrets for tests to pass 🫡

@MinhxNguyen7
Copy link
Member

MinhxNguyen7 commented Dec 22, 2024

You can actually add it to the build script, since that's a repository secret that is accessible from the workflow. You can see that because the workflow run shows the API key being available.

You should give it a try if you want to learn more about our devops. It's just one line. If you don't want to bother, I can do it.

@KevinWu098
Copy link
Member Author

You can actually add it to the build script, since that's a repository secret that is accessible from the workflow. You can see that because the workflow run shows the API key being available.

You should give it a try if you want to learn more about our devops. It's just one line. If you don't want to bother, I can do it.

Sorry, I'm not totally following -- I might be confused here, but I need repository-level access permissions to edit secrets, which I don't have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix build step in testing workflow
2 participants