Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cache websoc #1086

Merged
merged 3 commits into from
Jan 7, 2025
Merged

feat: cache websoc #1086

merged 3 commits into from
Jan 7, 2025

Conversation

KevinWu098
Copy link
Member

Summary

  1. Reintroduces websoc result caching, which was removed in feat: migrate to Anteater API #1031
  2. Updates eslint at root to v9 with the flat config
npx @eslint/migrate-config .eslintrc.cjs

Test Plan

  1. Search for a course
  2. Switch tabs or otherwise clear the search
  3. Searching for the course again should hit the cache (no loading state), and it should also scroll to the appropriate height that you last left off on (feat: mobile ui and saved scroll position #1001 was also regressed by feat: migrate to Anteater API #1031)
  4. Searching for a different course should not hit that cache

Issues

Closes #

Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MinhxNguyen7 MinhxNguyen7 merged commit 3684b2a into main Jan 7, 2025
4 checks passed
@MinhxNguyen7 MinhxNguyen7 deleted the kwu/cache-websoc branch January 7, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codefix Refactoring or improving the codebase
Projects
Status: Done 🤩
Development

Successfully merging this pull request may close these issues.

2 participants