-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Class Search Shortcut #1092
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid PR, I think users will be really happy with this improvement to the user flow around the app.
That said, I have a few questions about the approach we're taking in this PR. More specifically, I don't feel that we need to use a new store in order to implement the logic for this feature.
Short of refactoring RightPaneStore
to a Zustand store, I think this PR should reuse logic from CourseInfoSearchButton
and utilize RightPaneStore
and CoursePaneStore
over creating another store with duplicate states
apps/antalmanac/src/components/RightPane/SectionTable/CourseInfo/CourseInfoSearchButton.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/CoursePane/CoursePaneRoot.tsx
Outdated
Show resolved
Hide resolved
Apologies for the slow development speed |
Summary
Users can now quickly search for courses they've selected by clicking a shortcut in in their calendar
A new button is added to the course popup when you click on the calendar event which will auto search the course offerings. Additionally,
cmd/ctrl
+click
on a calendar event will perform the search.This is meant to enhance the user experience by reducing the redundancy of having re-search a course if a user wants to select or preview different time slots
Screen.Recording.2024-12-29.at.8.26.15.PM.mov
Test Plan
cmd/ctrl
+click
to search the courseAdded
orMap
pages and you try either 1. or 2. nothing should happenIssues
Closes #1046