Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist column filters using local storage #1096

Merged

Conversation

Dezert01
Copy link
Contributor

Summary

Add persistence for column toggles using local storage. The selected column toggles are saved automatically when toggled and restored on page load.

Test Plan

  1. Verify that all column toggles are checked on the first page load by default
  2. Confirm that changes are saved to local storage when toggling on or off
  3. Refresh the page and verify that the toggles remain as they were set before the refresh

Issues

Closes #1075

@Dezert01
Copy link
Contributor Author

@MinhxNguyen7 Hi! Could you check this out and let me know if it’s what you had in mind? Open to any feedback!

@MinhxNguyen7 MinhxNguyen7 self-requested a review December 31, 2024 19:20
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MinhxNguyen7 MinhxNguyen7 merged commit d27e7b7 into icssc:main Jan 6, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist column filters
2 participants