Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/search by section code #1129

Merged
merged 4 commits into from
Jan 22, 2025
Merged

feat/search by section code #1129

merged 4 commits into from
Jan 22, 2025

Conversation

jotalis
Copy link
Contributor

@jotalis jotalis commented Jan 22, 2025 •
edited by MinhxNguyen7
Loading

Summary

  • Search for course section by its sectionCode (not using fuzzy search)
  • Fetch and store 400,000 course codes by term using Anteater API's GraphQL endpoint
  • Autofill suggestions if 4 digits are inputted

Test Plan

  • Run the backend locally
  • Route the trpc endpoint in trpc.ts to use local backend
  • Search for courses by their course code using 4-5 digits (including left padded ones e.g., 05001)
  • Ensure correct course is displayed

Issues

Future Followup

  • Will add support for generating terms in another PR

@jotalis jotalis marked this pull request as ready for review January 22, 2025 07:51
adcockdalton
adcockdalton approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@adcockdalton adcockdalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally.

@adcockdalton adcockdalton merged commit 4915764 into main Jan 22, 2025
4 checks passed
MinhxNguyen7 added a commit that referenced this pull request Jan 22, 2025
@MinhxNguyen7
Revert "feat/search by section code (#1129)"
b82f6d0 
This reverts commit 4915764.
@MinhxNguyen7 MinhxNguyen7 mentioned this pull request Jan 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adcockdalton adcockdalton adcockdalton approved these changes

@MinhxNguyen7 MinhxNguyen7 Awaiting requested review from MinhxNguyen7

@KevinWu098 KevinWu098 Awaiting requested review from KevinWu098

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jotalis @adcockdalton