-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPA and Grade Distribution in Search Results #671
Conversation
Co-authored-by: Eric Pedley <[email protected]> Co-authored-by: alanchangxyz <[email protected]>
Co-authored-by: Kevin Wu <[email protected]>
Co-authored-by: Aponia <[email protected]>
Co-authored-by: Aponia <[email protected]>
@ap0nia review pls so I can finally be done with this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks very clean for the most part ✨
The column store and its usage can be tweaked to improve the reactivity.
apps/antalmanac/src/components/RightPane/CoursePane/CoursePaneButtonRow.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/CoursePane/CoursePaneButtonRow.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/CoursePane/CoursePaneButtonRow.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/SectionTable.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/SectionTable.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/SectionTable.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/SectionTable.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 💯
Summary
Adds GPA as a section table column. Clicking on the GPA number shows the grade distribution of that class taught by the particular instructor. If there are multiple instructors, the first one on which we have data will be used.
Note:
TODO
Make sure added courses pane doesn't send duplicate requests due to race condition in caching.Disable GPA column in added courses pane.Test Plan
See that the GPA data shows up correctly for all kinds of searches and the graph reliably shows and hides intuitively/as expected.
See if styling needs improvement on both mobile and desktop.
Issues
Closes #599
Part of #440
Future Follow-up
Have more information in graph like ZotCourse