Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPA and Grade Distribution in Search Results #671

Merged
merged 94 commits into from
Oct 13, 2023
Merged

GPA and Grade Distribution in Search Results #671

merged 94 commits into from
Oct 13, 2023

Conversation

MinhxNguyen7
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 commented Aug 23, 2023

Summary

Adds GPA as a section table column. Clicking on the GPA number shows the grade distribution of that class taught by the particular instructor. If there are multiple instructors, the first one on which we have data will be used.

image

Note:

  • There's some creep with changing how the table is styled, but it was necessary because the GPA column would make the table too cramped on mobile otherwise.
  • There's a refactor of the columns store to Zustand in a separate module instead of RightPaneStore. I considered it justified because I needed to change the logic somewhat. I have some empathy for Brian's refactoring zeal now.

TODO

  • GPA column and cell
  • Styling
    • GPA number
    • Give table min width depending on number of columns shown and force side scroll
  • Close GPA graph on clickaway
  • Make sure added courses pane doesn't send duplicate requests due to race condition in caching. Disable GPA column in added courses pane.
  • Update PP API endpoint to prod

Test Plan

See that the GPA data shows up correctly for all kinds of searches and the graph reliably shows and hides intuitively/as expected.

See if styling needs improvement on both mobile and desktop.

Issues

Closes #599
Part of #440

Future Follow-up

Have more information in graph like ZotCourse
image

@MinhxNguyen7 MinhxNguyen7 added the enhancement Improvements to the user experience label Aug 23, 2023
@MinhxNguyen7 MinhxNguyen7 self-assigned this Aug 23, 2023
@github-actions github-actions bot requested a review from teresa-liang August 23, 2023 03:27
@MinhxNguyen7 MinhxNguyen7 marked this pull request as draft August 23, 2023 12:53
@MinhxNguyen7 MinhxNguyen7 mentioned this pull request Aug 22, 2023
7 tasks
@MinhxNguyen7 MinhxNguyen7 marked this pull request as ready for review August 23, 2023 14:13
@github-actions github-actions bot requested a review from Douglas-Hong August 23, 2023 14:13
@MinhxNguyen7 MinhxNguyen7 requested a review from ap0nia September 16, 2023 17:44
@MinhxNguyen7
Copy link
Member Author

@ap0nia review pls so I can finally be done with this

Copy link
Collaborator

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks very clean for the most part ✨

The column store and its usage can be tweaked to improve the reactivity.

@MinhxNguyen7 MinhxNguyen7 requested a review from ap0nia October 12, 2023 16:49
Copy link
Collaborator

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 💯

@ap0nia ap0nia merged commit 38bf45e into main Oct 13, 2023
6 checks passed
@ap0nia ap0nia deleted the gpa branch October 13, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to the user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

GPA and Grade Distribution in Search Results
5 participants