Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Added Pane Course Grouping #711

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix Added Pane Course Grouping #711

merged 1 commit into from
Sep 29, 2023

Conversation

KevinWu098
Copy link
Member

Summary

Screenshot 2023-09-28 at 8 04 25 PM

This piece of filtering was too general for the courses that shared the same courseNumber and deptCode (EECS 298, BIO SCI 199, etc). Because they all have different course titles, however, the fix is simply to narrow down the filter even more with .courseTitle.

Old Code ->

        let formattedCourse = formattedCourses.find(
            (needleCourse) =>
                needleCourse.courseNumber === course.courseNumber && needleCourse.deptCode === course.deptCode

Test Plan

Make sure courses like BIO SCI 199 are properly grouped, as well as that no other functionality has been broken.

Issues

Closes #

Copy link
Member

@EricPedley EricPedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🚢🚢🚢🚢🚢

@EricPedley EricPedley merged commit 738b58b into main Sep 29, 2023
7 checks passed
@EricPedley EricPedley deleted the overlapping-courses-bug branch September 29, 2023 23:13
MinhxNguyen7 pushed a commit that referenced this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants