Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize Schedule Load Websoc Requests #713

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Conversation

EricPedley
Copy link
Member

@EricPedley EricPedley commented Sep 29, 2023

Summary

Saves a bunch of time on schedule loading by making PPAPI requests for different terms concurrently.

Before:
image

After:
image

Test Plan

Verify with network inspector that requests are being done concurrently, and also that nothing breaks.

Issues

Closes #712

Copy link
Collaborator

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good optimization 🚀

apps/antalmanac/src/stores/Schedules.ts Outdated Show resolved Hide resolved
apps/antalmanac/src/stores/Schedules.ts Outdated Show resolved Hide resolved
@EricPedley EricPedley requested review from MinhxNguyen7 and removed request for teresa-liang and KevinWu098 September 30, 2023 21:45
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MinhxNguyen7 MinhxNguyen7 merged commit 7291bf2 into main Oct 1, 2023
@MinhxNguyen7
Copy link
Member

Blazing

MinhxNguyen7 pushed a commit that referenced this pull request Oct 1, 2023
@ap0nia ap0nia deleted the fast-loading branch October 10, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load schedules faster
3 participants