refactor: made course pane components functional #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap0nia
requested review from
EricPedley and
MinhxNguyen7
and removed request for
JacE070
EricPedley
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Only reading the last commit that replaces the state hook with a reducer hook, and that looks good to me. Trusting Minh's approval for the rest. @ap0nia if you're ready to merge can you press the button? Not sure if you wanted to throw in anything else before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If we want to support more sophisticated searching, then we'd want to integrate better with react-router so that we can manage state in the URL. This is in regards to #558 and the work that's being done on a fork by Carlos
The core component logic has been mostly preserved and optimized for functional components.
Test Plan
I can write tests, if anybody wants me to. Some tests I can think of at the top of my head are: