-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Color Changing Bug w/ Duplicate Courses #719
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinWu098
commented
Oct 5, 2023
KevinWu098
changed the title
[WIP] Fix Color Changing Bug w/ Duplicate Courses
fix: Color Changing Bug w/ Duplicate Courses
Oct 15, 2023
EricPedley
suggested changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Results look good, just a few comments about the implementation
apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/CoursePane/CourseRenderPane.tsx
Outdated
Show resolved
Hide resolved
EricPedley
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢🚢🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
screen-recorder-sat-sep-30-2023-15-39-24.1.webm
As shown above (and in #716), changing colors of a course event fails if the same course event exists in a schedule that is lower in index than the one currently being changed.
The reason for this is that
getExistingCourse
(shown below) only returned the reference of a singular course that matched the given params. This meant that courses (which matched the params) in other schedules would not have their colors changed.TL;DR Color Picker and Courses will now correctly update their colors (without affecting other schedules and courses)
Test Plan
Issues
Closes #716