-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: locations for custom events #726
Conversation
Can you convert this to a draft until it's ready for review? Just makes our PR list easier to track. |
Is this PR done? There seems to be another TODO. I strongly think that it would make sense for it to work with routing. |
I finished the intended features and is waiting for review and merge |
![]() Unless I'm mistaken, the latest staging instance doesn't have the map routing? Clicking a location also leads to https://staging-726.antalmanac.com/map?location=0 |
Maybe because of the Conflicts? Yea, the instance is differ from my local |
@ap0nia Would you happen to know why the instance differs from my local deployment? And also why the tests failed. (For the newest instance I merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good if the routing worked, but I'm in favor of getting this out the door, then working on that.
Otherwise, LGTM!
OK i will come back to this problem after |
Summary
A continuation of #586 . I'll be collaborating with @stevenguyukai to prepare all the features.
Features
TODO