Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open error snackbar when we get an error during search #749

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

EricPedley
Copy link
Member

Summary

Open an error snackbar and log to console when we get an error during search. This shouldn't trigger when we legitimately can't find

Test Plan

Search up a class not offered this quarter, and it shouldn't open the error snackbar. Rn the API is flaky so if you search enough times you'll be able to see an error, and verify on the network tab the request didn't work.

@EricPedley EricPedley requested a review from ap0nia October 19, 2023 18:27
@github-actions github-actions bot requested a review from teresa-liang October 19, 2023 18:27
Copy link
Collaborator

@ap0nia ap0nia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic 🚀

@EricPedley EricPedley requested review from ap0nia and removed request for teresa-liang October 19, 2023 18:27
@EricPedley EricPedley merged commit 570bf94 into main Oct 23, 2023
7 checks passed
@EricPedley EricPedley deleted the search-error-verbosity branch October 23, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants