Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Marker Popup Styling #757

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Update Marker Popup Styling #757

merged 4 commits into from
Oct 26, 2023

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Oct 25, 2023

Summary

Many moons ago, devsdevsdevs asked for "a more compliant and aesthetic design for [the Map Popup]."

Slightly fewer moons ago, the team @ Design at UCI created a Figma design for what a revamped AntAlmanac would look like.

Currently, we are 39 moons post the original issue! This PR is entirely visual, and aims to be as true to the DaUCI design as possible!

Orginal:
Screenshot 2023-10-25 at 4 21 50 PM

Left is DaUCI, right is my implementation:

Screenshot 2023-10-25 at 3 43 50 PM

Test Plan

The change is visual in nature, but there are a few cases that I'd like to cover

  1. The default -- does it look good?
  2. When there is no image
  3. When there is no location (?)
  4. Light and Dark Mode

Issues

Closes #127

Copy link
Member

@EricPedley EricPedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@EricPedley EricPedley merged commit 65c1afd into main Oct 26, 2023
7 checks passed
@ap0nia ap0nia deleted the pretty-map-popup branch November 8, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maps: Customize the popup with compliant design
2 participants