Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: remove duplicate buildings from the catalogue" #785

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

KevinWu098
Copy link
Member

Reverts #779

Reasoning:

    const validBuildingCodes = [...uniqueBuildingCodes].filter(
        (buildingCode) => buildingCatalogue[locationIds[buildingCode]] != null
    );

This is the reason why (from Map.tsx) ^^

The changes in #779, although confirmed to still work for all of the locations in map search, didn't take into account that location_ids.ts are the apparent source of truth for which ID in the list is the one we use. There may be more discrepancies still, but this is likely the source of the issue here

Originally noted in #784 ^^

Screenshot 2023-11-03 at 1 47 57 PM

@github-actions github-actions bot requested a review from MinhxNguyen7 November 3, 2023 20:48
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MinhxNguyen7 MinhxNguyen7 merged commit a9bb76e into main Nov 3, 2023
5 of 6 checks passed
@ap0nia ap0nia deleted the revert-779-remove-duplicate-buildings branch November 8, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants