Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Lighter Calendar Lines #789

Merged
merged 4 commits into from
Nov 9, 2023
Merged

feat: Lighter Calendar Lines #789

merged 4 commits into from
Nov 9, 2023

Conversation

KevinWu098
Copy link
Member

@KevinWu098 KevinWu098 commented Nov 4, 2023 •
edited
Loading

Summary

Lower the opacity of half-hour lines, making the calendar (hopefully) appear less dated

Old:
Screenshot 2023-11-08 at 9 41 00 PM
Screenshot 2023-11-08 at 9 41 04 PM

New:
Screenshot 2023-11-08 at 9 40 50 PM
Screenshot 2023-11-08 at 9 40 54 PM

Test Plan

  1. As a 100% CSS PR, check it out in both light and dark mode and make sure that it remains readable.

Issues

Closes #781

@KevinWu098 KevinWu098 changed the title WIP: Add even selector WIP: Lighter Calendar Lines Nov 6, 2023
@KevinWu098 KevinWu098 marked this pull request as ready for review November 9, 2023 05:40
@KevinWu098 KevinWu098 changed the title WIP: Lighter Calendar Lines Lighter Calendar Lines Nov 9, 2023
@KevinWu098 KevinWu098 changed the title Lighter Calendar Lines feat: Lighter Calendar Lines Nov 9, 2023
EricPedley
EricPedley approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@EricPedley EricPedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

MinhxNguyen7
MinhxNguyen7 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@MinhxNguyen7 MinhxNguyen7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EricPedley EricPedley merged commit bfb0f86 into main Nov 9, 2023
@EricPedley EricPedley deleted the lighter-calendar-lines branch November 9, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricPedley EricPedley EricPedley approved these changes

@MinhxNguyen7 MinhxNguyen7 MinhxNguyen7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: Lighter calendar grid lines
3 participants
@KevinWu098 @EricPedley @MinhxNguyen7