-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create Snackbar When Copying Schedules #811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm not sure if my type definition for the CallbackOptions is proper, so just lmk if there's a better way to do them @ap0nia export interface CallbackOptions {
onSuccess: (name?: string) => unknown;
onError: (name?: string) => unknown;
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing the strategy 🙏
I think the original function signature should be completely preservable, i.e. it should accept just the index and possibly options. The options will be callback functions that will be called with the index after a successful/unsuccessful attempt to copy the schedule.
The callback functions can figure out the schedule name by indexing the array of schedule names with the index they were called with.
apps/antalmanac/src/components/RightPane/AddedCourses/AddedCoursePane.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/AddedCourses/AddedCoursePane.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Aponia <[email protected]>
Co-authored-by: Aponia <[email protected]>
…rsePane.tsx Co-authored-by: Aponia <[email protected]>
…rsePane.tsx Co-authored-by: Aponia <[email protected]>
Co-authored-by: Aponia <[email protected]>
Co-authored-by: Aponia <[email protected]>
I kinda wanna write tests for it, but I don't wanna write tests for it lol. What do you wanna do Kevin? If you don't wanna test, then I'll just approve and merge 🤓 |
If it breaks it breaks, and somebody gets extra contribution history 😋 |
TLDR let's merge 😅, do you need me to do a noop? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work refactoring. This was more involved than it could've been otherwise, but I have to slow down Kevin from moving too fast 💯
Yeah I think I need an extra commit from someone aside from me lol. Unless you're able to merge it yourself. |
Summary
Test Plan
Issues
Closes #