-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Past Enrollment Popup #820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feature, looks great. Only have a few readability suggestions.
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🚀
Most of the improvements are regarding JS syntax. The comments regarding lower level implementation details can be applied at your discretion.
apps/antalmanac/src/components/RightPane/SectionTable/SectionTable.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 🚀
All the comments I left were personal opinions. Feel free to peruse them before merging!
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Outdated
Show resolved
Hide resolved
apps/antalmanac/src/components/RightPane/SectionTable/EnrollmentHistoryPopup.tsx
Show resolved
Hide resolved
Addressed changes, and approved by Brian
Co-authored-by: Minh Nguyen <[email protected]>
Summary
Demo:
enrollmentDemo.mp4
TODO
Test Plan
queryEnrollmentHistory
to return null).Issues
Closes #341
Closes #182
Future Followup